Nit picks

News and discussion about beta versions and CVS changes
User avatar
matt_t_hat
Posts: 1123
Joined: Sun Aug 21, 2005 4:45 pm
Location: UK
Contact:

Nit picks

Postby matt_t_hat » Fri Jul 20, 2012 3:49 pm

Things I noticed that are not critical but could do with a tweak:


1.
On line 1492 of globalfunction in the function createLink($type, $params) there is a line of code that seems a touch pointless:

Code: Select all

$generatedURL = '';


Once initialised this variable is never used again. The rest of the function talks of $url wich is uninitialised and yet pass byref.

2.
ticketForPlugin() sets $CONF global but does not use it.

3.
If the $CONF['debug'] = true; on glloobalfuntion had an if isset done first then the CONF value could be set somewhere useful like index.php or config.php Just an idea.

Stay cool.

Return to “Core Development”